Skip to content

ci: swap buildjet/setup-node for actions/setup-node v6.4.0#3497

Merged
nicktrn merged 2 commits intomainfrom
ci/swap-buildjet-setup-node
May 1, 2026
Merged

ci: swap buildjet/setup-node for actions/setup-node v6.4.0#3497
nicktrn merged 2 commits intomainfrom
ci/swap-buildjet-setup-node

Conversation

@nicktrn
Copy link
Copy Markdown
Collaborator

@nicktrn nicktrn commented May 1, 2026

Last action still firing the Node 20 deprecation warning after #3494. buildjet/setup-node@v4.0.4 (the latest tag) declares runs: using: 'node20' and the repo hasn't shipped a node24 update.

Workflows here run on ubuntu-latest (not buildjet runners), so the buildjet fork wasn't giving us anything we don't get from actions/setup-node directly. Swapping to actions/setup-node@v6.4.0 (node24 runtime) silences the warning.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 1, 2026

⚠️ No Changeset found

Latest commit: 0364c1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 60233490-096d-4896-a159-0fb772d307a7

📥 Commits

Reviewing files that changed from the base of the PR and between cb94382 and b1d9a0b.

📒 Files selected for processing (10)
  • .github/workflows/changesets-pr.yml
  • .github/workflows/claude.yml
  • .github/workflows/e2e-webapp.yml
  • .github/workflows/e2e.yml
  • .github/workflows/release.yml
  • .github/workflows/sdk-compat.yml
  • .github/workflows/typecheck.yml
  • .github/workflows/unit-tests-internal.yml
  • .github/workflows/unit-tests-packages.yml
  • .github/workflows/unit-tests-webapp.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-15T10:48:02.687Z
Learning: Use pnpm as the package manager (version 10.23.0 or later) and Node.js 20.20.0
📚 Learning: 2026-01-15T10:48:02.687Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-15T10:48:02.687Z
Learning: Use pnpm as the package manager (version 10.23.0 or later) and Node.js 20.20.0

Applied to files:

  • .github/workflows/e2e-webapp.yml
  • .github/workflows/typecheck.yml
  • .github/workflows/e2e.yml
  • .github/workflows/changesets-pr.yml
  • .github/workflows/unit-tests-webapp.yml
  • .github/workflows/unit-tests-packages.yml
  • .github/workflows/unit-tests-internal.yml
  • .github/workflows/sdk-compat.yml
  • .github/workflows/release.yml
  • .github/workflows/claude.yml
📚 Learning: 2026-04-15T15:39:06.868Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-15T15:39:06.868Z
Learning: When modifying any public package (`packages/*` or `integrations/*`), add a changeset using `pnpm run changeset:add`.

Applied to files:

  • .github/workflows/changesets-pr.yml
  • .github/workflows/unit-tests-packages.yml
🔇 Additional comments (18)
.github/workflows/e2e-webapp.yml (1)

53-57: Looks good.

The setup-node swap is consistent here, and the Node 20.20.0 / pnpm cache configuration is preserved.

.github/workflows/typecheck.yml (1)

24-28: Looks good.

This is a clean action version bump; the Node 20.20.0 and pnpm settings are preserved.

.github/workflows/e2e.yml (1)

36-40: Looks good.

The setup-node swap is consistent with the rest of the workflow, and the Node version remains unchanged.

.github/workflows/release.yml (2)

86-90: Looks good.

This setup-node update preserves the existing Node 20.20.0 and pnpm cache configuration in the release job.


255-259: Looks good.

This prerelease job update is consistent with the release job, and the Node 20.20.0 / pnpm settings remain unchanged.

.github/workflows/claude.yml (1)

38-42: Looks good.

The setup-node swap is isolated and keeps the existing Node 20.20.0 / pnpm configuration intact.

.github/workflows/unit-tests-packages.yml (2)

58-63: Looks good.

The setup-node swap preserves the existing Node 20.20.0 and pnpm cache behavior in the unit test job.


127-131: Looks good.

This merge-reports job keeps the same no-cache setup while updating the setup-node action version.

.github/workflows/changesets-pr.yml (2)

35-39: Looks good.

The setup-node update keeps the release-pr job on Node 20.20.0 with pnpm caching intact.


93-97: Looks good.

This update is consistent with the rest of the workflow and preserves the existing Node version.

.github/workflows/sdk-compat.yml (4)

30-34: Looks good.

This setup-node swap preserves the existing Node matrix value and pnpm cache behavior.


68-72: Looks good.

The Bun compatibility job keeps the same Node 20.20.0 / pnpm configuration after the action update.


109-113: Looks good.

The Deno compatibility job retains the same Node 20.20.0 and pnpm setup while updating the action pin.


154-158: Looks good.

The Cloudflare compatibility job is unchanged apart from the setup-node action version.

.github/workflows/unit-tests-webapp.yml (2)

58-62: Looks good.

The actions/setup-node swap preserves the existing Node 20.20.0 and pnpm cache configuration in unitTests.


135-139: Looks good.

The merge-reports job keeps the same behavior while moving to the newer setup-node action, which matches the PR goal.

.github/workflows/unit-tests-internal.yml (2)

58-62: Looks good.

The actions/setup-node swap preserves the existing Node 20.20.0 and pnpm cache configuration in unitTests.


127-131: Looks good.

The merge-reports job keeps the same behavior while moving to the newer setup-node action, which matches the PR goal.


Walkthrough

This pull request updates GitHub Actions workflows across ten files by replacing the Node.js setup action from buildjet/setup-node@v4.0.4 with actions/setup-node@v6.4.0. The Node.js runtime version (20.20.0) and pnpm caching configuration remain unchanged across all affected workflows. No logic or functionality changes are introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing required template sections: Closes issue reference, checklist, Testing, Changelog, and Screenshots sections are absent or incomplete. Add the missing template sections including issue reference, completed checklist items, testing steps, changelog entry, and appropriate screenshots if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing buildjet/setup-node with actions/setup-node v6.4.0 across CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/swap-buildjet-setup-node

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 6/8 reviews remaining, refill in 10 minutes and 1 second.

Comment @coderabbitai help to get the list of available commands and usage tips.

@nicktrn nicktrn added the ready label May 1, 2026
@nicktrn
Copy link
Copy Markdown
Collaborator Author

nicktrn commented May 1, 2026

ready

@nicktrn nicktrn merged commit 1594080 into main May 1, 2026
39 checks passed
@nicktrn nicktrn deleted the ci/swap-buildjet-setup-node branch May 1, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants